api: add handling for xds.type.v3.TypedStruct#18567
api: add handling for xds.type.v3.TypedStruct#18567mattklein123 merged 10 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
repokitteh-read-only
bot
added
api
deps
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
This reverts commit 3c1eec6. Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
markdroth
requested review from
alyssawilk,
antoniovicente and
mattklein123
as code owners
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM. Can you add some type of release note about this?
/wait
Signed-off-by: Mark D. Roth <roth@google.com>
|
Release note added. PTAL. Thanks! |
| * ext_authz: added :ref:`query_parameters_to_set <envoy_v3_api_field_service.auth.v3.OkHttpResponse.query_parameters_to_set>` and :ref:`query_parameters_to_remove <envoy_v3_api_field_service.auth.v3.OkHttpResponse.query_parameters_to_remove>` for adding and removing query string parameters when using a gRPC authorization server. | ||
| * http: added support for :ref:`retriable health check status codes <envoy_v3_api_field_config.core.v3.HealthCheck.HttpHealthCheck.retriable_statuses>`. | ||
| * thrift_proxy: add upstream response zone metrics in the form ``cluster.cluster_name.zone.local_zone.upstream_zone.thrift.upstream_resp_success``. | ||
| * api: added support for *xds.type.v3.TypedStruct* in addition to the now-deprecated *udpa.type.v1.TypedStruct* proto message. |
There was a problem hiding this comment.
This is not going to pass format, it needs to be alpha sorted, can you move it to the top? Also, while you are here is it possible to add more color to this? I'm not sure most users are going to understand what this means. Not sure if there is anything that can be linked to, etc.
/wait
There was a problem hiding this comment.
The only docs that I know of on this are the comments in the proto file in the cncf/xds repo. I've added an HTTP link to there, since I don't think there's a direct way to use an RST ref in this case.
There was a problem hiding this comment.
...and it looks like RST isn't happy with the external HTTP link. So I don't think there's any reasonable way to add a link here, but I did leave a short explanation of what the proto message is for.
There was a problem hiding this comment.
RST uses a slightly different format from MD for external links: https://sublime-and-sphinx-guide.readthedocs.io/en/latest/references.html#links-to-external-web-pages
There was a problem hiding this comment.
That's exactly the syntax I was using, but it failed the presubmit (log):
/tmp/tmpwbaogaun/generated/rst/version_history/current.rst:36: WARNING: Unknown target name: "a wrapper proto used to encode typed json data in a *google.protobuf.any* field<https://github.com/cncf/xds/blob/cb28da3451f158a947dfc45090fe92b07b243bc1/xds/type/v3/typed_struct.proto>".
There was a problem hiding this comment.
OK pretty sure this should work but nbd, thanks for trying.
Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Mark D. Roth <roth@google.com>
2 participants
Commit Message: api: add handling for xds.type.v3.TypedStruct
Additional Description: Adds handling for the new xds.type.v3.TypedStruct, but retains handling for legacy type udpa.type.v1.TypedStruct.
Risk Level: Low
Testing: Updated unit tests
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A
Another step toward cncf/xds#2.